Extract Collector Store seam#6
Merged
Merged
Conversation
Amorpheuz
marked this pull request as ready for review
July 14, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeutiland rewire Collector readers and writers through the new seamsWhy
Collector persistence behavior was spread across
db.py, analytical modules, and tests. That made transaction ownership unclear, allowed private database helpers to leak across modules, and left local and CI validation inconsistent.This change implements the Store boundary described by ADR-0001 while preserving the existing schema and response behavior.
Impact
Contributors get one explicit persistence boundary: analytical readers retain SQL ownership, while mutations go through serialized Store write transactions. Runtime API, Session, Event, Origin, ingest, and Insights behavior remain unchanged.
Validation
135 passedon Python 3.12ruff check backendFollow-up
collector-checksas required in the default branch ruleset after this workflow first runs.